• posted a message on Simple iLevel

    It seems as though, currently, GetItemInfo returns the Ilevel of the weapon without adding the bonus levels from relics upgraded by the crucible.  So blizz shows my weapon as 960 but GetItemInfo returns 945, the only way I've seen to get whether the relics have the first tier upgraded only seems to work for the players weapon and not everyone else.  In my local version I'm merely adding 15 to the itemLevel, with the assumption that everyone has their relics upgraded until a better solution comes about.

    Link Removed
  • posted a message on Bagnon

    The 7.3.1 version works fine.

    Link Removed
  • posted a message on Simple iLevel

    Pretty sure there are two things wrong here, in SimpleILevel.lua Lines 611 to 614 are:

    		local mainHandArtifact = false;
    		local mainHandItemLevel = 0;
    		local offHandArtifact = false;
    		local offHandItemLevel = 0;

     However, these should be (notice the = 0 is removed):

    		local mainHandArtifact = false;
    		local mainHandItemLevel;
    		local offHandArtifact = false;
    		local offHandItemLevel;

    Next on Line 667 and 671 (respectively):

    		if offHandArtifact and offHandArtifact and mainHandItemLevel > offHandItemLevel then
    
    		elseif offHandArtifact and offHandArtifact and mainHandItemLevel < offHandItemLevel then

    However these should be:

    		if mainHandArtifact and offHandArtifact and mainHandItemLevel > offHandItemLevel then
    
    		elseif mainHandArtifact and offHandArtifact and mainHandItemLevel < offHandItemLevel then

     

    For me there is a bit too much back and worth evaluation and then checking afterward for certain criteria, making the routine needlessly complex. In my local version I use a different GearSum routine, which I detailed in a previous comment:

    https://mods.curse.com/addons/wow/simple-ilevel?comment=426

    Link Removed
  • posted a message on Simple iLevel
    Quote from healarious85 >>

    I am having the same problem. Any way you could explain the solution with a bit more detail. If you are talking about something in game, I don't see an option for that. Help please!

    Sure thing.  In SimpleILevel\SimpleILevel.lua on line 660 the if statement will never be evaluated as true:

    if not offHandItemLevel and mainHandItemLevel then

    The problem here, is that offHandItemLevel is initialized to 0, so it can never be nil and thus the 'not offHandItemLevel' will always evaluate false.  To fix this evaluation change lines 612 and 614 from:

    		local mainHandItemLevel = 0;
    		local offHandArtifact = false;
    		local offHandItemLevel = 0;

     to:

    		local mainHandItemLevel;
    		local offHandArtifact = false;
    		local offHandItemLevel;

    This should fix it up so that 2-handed weapons are evaluated properly.

    Now, in my opinion the entire GearSum routine is a bit overly complex, for my local copy of SiL i replaced the SIL:GearSum routine with the following:

    function SIL:GearSum(items, level)
      if items and level and type(items) == 'table' then
        local totalItems = 0;
        local totalScore = 0;
    
        for i,itemLink in pairs(items) do
          if itemLink then
            local name, link, itemRarity , itemLevelBlizz = GetItemInfo(itemLink);
            local itemLevel = self.itemUpgrade:GetUpgradedItemLevel(itemLink);
            -- print(totalItems, i, itemLevel, itemRarity, itemLink);
            if itemLevel and not ( i == INVSLOT_BODY or i == INVSLOT_RANGED or i == INVSLOT_TABARD )  then
              totalItems = totalItems + 1;
              if itemLevelBlizz > itemLevel then itemLevel = itemLevelBlizz; end
              if itemRarity == 6 then
                -- Bypass caching in LibItemUpgradeInfo-1 if need be
                self:Debug('Artifact!', i, itemLink, itemLevel, itemLevelBlizz);
                if not items[INVSLOT_OFFHAND] and i == INVSLOT_MAINHAND then
                  totalScore = totalScore + itemLevel * 2;
                  totalItems = totalItems + 1;
                  self:Debug("There is NO offhand, using mainhand", itemLevel);
                elseif i == INVSLOT_MAINHAND then
                  if (itemLevel >= select(4, GetItemInfo(items[INVSLOT_OFFHAND]))) then
                    totalScore = totalScore + (itemLevel * 2);
                    self:Debug('mainHandItemLevel > offHandItemLevel, using score from mainHand.');
                  else
                    totalScore = totalScore + (select(4, GetItemInfo(items[INVSLOT_OFFHAND])) * 2);
                    self:Debug('mainHandItemLevel < offHandItemLevel, using score from offHand.');
                  end
                end
              else
                -- Normal item
                totalScore = totalScore + itemLevel;
              end
            end
          end
        end
    
        return totalScore, totalItems;
      else
        return false;
      end
    end
    Link Removed
  • posted a message on Bagnon

    Odd that curse/twitch are not showing the latest file/push, should be version 7.3.1:

    https://wow.curseforge.com/projects/bagnon/files

    Link Removed
  • posted a message on Bagnon

    Yep, just a couple missed lines in the commit, see my comment:

     

    https://mods.curse.com/addons/wow/bagnon?comment=7183

    Link Removed
  • posted a message on Bagnon

    Yes, see my comment a bit below yours:

     

    https://mods.curse.com/addons/wow/bagnon?comment=7183

    Link Removed
  • posted a message on Bagnon

    To fix the Guild Bank:
    Bagnon_GuildBank/components/frame.lua has these values:

    Frame.CloseSound = 'GuildVaultClose'
    Frame.OpenSound = 'GuildVaultOpen'

    Should be changed to these:

    Frame.CloseSound = SOUNDKIT.GUILD_VAULT_CLOSE
    Frame.OpenSound = SOUNDKIT.GUILD_VAULT_OPEN

    Same with Bagnon_VoidStorage\components\frame.lua:

    Frame.OpenSound = 'UI_EtherealWindow_Open'
    Frame.CloseSound = 'UI_EtherealWindow_Close'

    It should be:

    Frame.OpenSound = SOUNDKIT.UI_EtherealWindow_Open
    Frame.CloseSound = SOUNDKIT.UI_EtherealWindow_Close
    Link Removed
  • posted a message on Bagnon

    Did you try downloading the following zipped up fix for this from the Project Issue #585:

    Bagnon_73_Ready.zip

     

    The folders (BagBrother, Bagnon, Bagnon_Config, Bagnon_GuildBank, Bagnon_VoidStorage) go directly into your wow Addon folder which has a default location of: c:\Program Files (x86)\World of Warcraft\Interface\AddOns

    Link Removed
  • posted a message on Bagnon

    Did you try downloading the following zipped up fix for this from the Project Issue #585:

    Bagnon_73_Ready.zip

     

    The folders (BagBrother, Bagnon, Bagnon_Config, Bagnon_GuildBank, Bagnon_VoidStorage) go directly into your wow Addon folder which has a default location of: c:\Program Files (x86)\World of Warcraft\Interface\AddOns

     

    Fyi Winzip is an alternative to Winrar, but on most current Windows OSs it can open zip files natively.

    Link Removed
  • To post a comment, please or register a new account.